[Woo POS] Coupons: Creation (with dummy entry point UI) #15467

staskus · 2025-04-01T14:30:04Z

Description

On POS, show existing IPP Coupon creation via a dummy entry point UI.

The main goal was to reuse two existing views:

AddEditCoupon
BottomSheetListSelectorViewController

I emulated the flow from the IPP flow:
Show BottomSheetListSelectorViewController for selecting coupon type (percentage / fixed) and then show AddEditCoupon for configuring the view.

I created POSCouponCreationSheet to encapsulate all the logic. The main complexity was around all the completion handlers so the modal dismissing and navigation would work properly on POS with SwiftUI.

The most notable change was to only refresh the view when the coupon success view is dismissed, not when the coupon code is successfully created to avoid issues that happen when the list is refreshed and the sheet still presented.

Steps to reproduce

Prerequisites: Enable enableCouponsInPointOfSale feature flag

Open POS
Select Coupons
Tap +, confirm 'Discount Type Selection' sheet appears
Confirm cancel closes, confirm cannot be dismissed with gesture
Select discount type, confirm 'Coupon Creation' sheet opens
Try to navigate in as many views as possible, change coupon codes, change values, change restrictions, dismiss and reopen
After configuring, tap create
Confirm success view appears
Dismiss the success view
Confirm coupon list is refreshed and a new coupon appears
Try to apply the coupon
Confirm the application works as expected

Testing information

Tested on both iOS 18 and iOS 17 to confirm that modal presentation works correctly. Put focus on testing as many dismissal, coming back and success combinations as possible.

Screenshots

new_coupon_flow.mp4

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

Display two existing views to emulate the IPP behavior: - Display discount type selector via BottomSheetListSelector - Display coupon creation view via AddEditCoupon

dangermattic · 2025-04-01T14:30:43Z

	1 Warning
⚠️	This PR is assigned to the milestone 22.1. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

wpmobilebot · 2025-04-01T14:40:32Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`29158`
	Version	`PR #15467`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`5efb9d0`
	Installation URL	2o171rr470slg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

…nCreationSheet

iamgabrielma

Works great! 🚢

For a separate PR (maybe not needed): I happened to have coupons disabled from Woo Settings when I was initially testing this:

⛔️ Error creating the coupon: Sorry, there was an issue with the server. Please try again later. (Error code: 403). Response: {"code":"woocommerce_rest_cannot_create","message":"Sorry, you are not allowed to create resources.","data":{"status":403}}
🔵 Tracked coupon_creation_failed, properties: [error_description: Sorry, there was an issue with the server. Please try again later. (Error code: 403). Response: {"code":"woocommerce_rest_cannot_create","message":"Sorry, you are not allowed to create resources.","data":{"status":403}}, blog_id: -1, error_domain: Networking.NetworkError, plan: , store_id: c5bd46cc-1804-4f7b-badb-bb98c449127f, error_code: 2, site_url: https://indiemelon.mystagingwebsite.com, is_wpcom_store: false, was_ecommerce_trial: false]

This happens after selecting the coupon type and filling all the info in the last step before creating it, which might be annoying, perhaps we want to add a call to check the coupon settings when we first tap on "+" and show some toast notification to enable coupons.

That said maybe nothing is necessary since we do this call as soon as we switch to the coupons tab and present an error screen, we just have to remember to disable the button or hide it on that case 👍

iamgabrielma · 2025-04-03T04:41:02Z

WooCommerce/Classes/ViewRelated/Coupons/Add and Edit Coupons/AddEditCoupon.swift

@@ -6,7 +6,7 @@ final class AddEditCouponHostingController: UIHostingController<AddEditCoupon> {

    private let viewModel: AddEditCouponViewModel

-    init(viewModel: AddEditCouponViewModel, onDisappear: @escaping () -> Void) {
+    init(viewModel: AddEditCouponViewModel, onDisappear: @escaping (_ success: Bool) -> Void) {


The success parameter makes sense in the context of this PR, but if I saw it out of the blue it might be tricky to understand what's the success referring to, like "success of disappear"? Would it make sense to rename the param to something like isCouponCreationSuccess, couponCreateResultCallback, or similar?

Thanks. If question like this comes up, then it definetely makes sense to clarify it 👍

staskus · 2025-04-03T10:08:16Z

That said maybe nothing is necessary since we do this call as soon as we switch to the coupons tab and present an error screen, we just have to remember to disable the button or hide it on that case 👍

I agree. I added that to the project requirements pdfdoF-6BG-p2

staskus added 3 commits April 1, 2025 16:10

Add dummy CTA for creating a Coupon

f00a74b

Update AddEditCouponViewModel initializer to set siteID value by default

366d0eb

Display Coupon Creation view from POS

6880124

Display two existing views to emulate the IPP behavior: - Display discount type selector via BottomSheetListSelector - Display coupon creation view via AddEditCoupon

staskus added type: task An internally driven task. feature: POS labels Apr 1, 2025

staskus added this to the 22.1 milestone Apr 1, 2025

staskus added 4 commits April 2, 2025 11:12

Move coupon creation sheet code into a self-contained modifier

9b40e82

Use consistent navigation view, titles, and dismiss logic in POSCoupo…

19d65e8

…nCreationSheet

Show coupon discount type selection sheet from coupon creation sheet

108f86b

Refresh coupons after successful coupon creation

cdd5262

staskus changed the title ~~[Woo POS] Coupons: Creation - Dummy Entry Point UI~~ [Woo POS] Coupons: Creation (with dummy entry point UI) Apr 2, 2025

staskus marked this pull request as ready for review April 2, 2025 12:00

staskus requested a review from iamgabrielma April 2, 2025 12:00

Make POSCouponDiscountType private

a0633a4

staskus mentioned this pull request Apr 2, 2025

[Woo POS] Coupons: Show error view when store has no coupons #15470

Merged

4 tasks

iamgabrielma approved these changes Apr 3, 2025

View reviewed changes

iamgabrielma self-assigned this Apr 3, 2025

staskus added 2 commits April 3, 2025 14:22

Use couponItem instead of success boolean to determine if item was added

27d7961

Add coupon to cart after the creation

5efb9d0

staskus enabled auto-merge April 3, 2025 11:24

staskus merged commit 89dc2a7 into trunk Apr 3, 2025
13 checks passed

staskus deleted the task/WOOMOB-212-woo-pos-coupon-creation branch April 3, 2025 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Woo POS] Coupons: Creation (with dummy entry point UI) #15467

[Woo POS] Coupons: Creation (with dummy entry point UI) #15467

staskus commented Apr 1, 2025 •

edited by iamgabrielma

Loading

dangermattic commented Apr 1, 2025 •

edited

Loading

wpmobilebot commented Apr 1, 2025 •

edited

Loading

iamgabrielma left a comment

iamgabrielma Apr 3, 2025

staskus Apr 3, 2025

staskus commented Apr 3, 2025

[Woo POS] Coupons: Creation (with dummy entry point UI) #15467

[Woo POS] Coupons: Creation (with dummy entry point UI) #15467

Conversation

staskus commented Apr 1, 2025 • edited by iamgabrielma Loading

Description

Steps to reproduce

Testing information

Screenshots

Reviewer (or Author, in the case of optional code reviews):

dangermattic commented Apr 1, 2025 • edited Loading

wpmobilebot commented Apr 1, 2025 • edited Loading

iamgabrielma left a comment

Choose a reason for hiding this comment

iamgabrielma Apr 3, 2025

Choose a reason for hiding this comment

staskus Apr 3, 2025

Choose a reason for hiding this comment

staskus commented Apr 3, 2025

staskus commented Apr 1, 2025 •

edited by iamgabrielma

Loading

dangermattic commented Apr 1, 2025 •

edited

Loading

wpmobilebot commented Apr 1, 2025 •

edited

Loading